Hi Orson, I have modified the incrementer control to unbind from the kill focus event. This meant I couldn't use a lambda - if you know how to unbind from a lambda without a lot of messing around, please let me know!
I have also made it so the increment GetValue will update the value before returning, otherwise things like Enter in a dialog can do an end run and not sanitise/update the value before returning. I have integrated your mods into the patch sequence in the appropriate places and rebased the branch onto master. Cheers, John On Fri, Feb 17, 2017 at 12:27 AM, John Beard <[email protected]> wrote: > Hi Orson, > > Thank you very much for checking! I see you found > my....deliberate...last minute mistakes! > > That's very strage about the enter thing, I certainly tried it before > but now I see a segfault as well. I will try to work out how to unbind > from a lambda, as I suspect you are right. > > Cheers, > > John > > On Fri, Feb 17, 2017 at 12:23 AM, Maciej Sumiński > <[email protected]> wrote: >> Hi John, >> >> Thank you very much, I see lots of great improvements here. Your branch >> is a good candidate for merge, but there is one problem. If I type a >> value in INCREMENT_TEXT_CTRL and hit Enter, pcbnew segfaults. I suspect >> that kill focus event handler is executed after the window is gone, but >> I am not fully sure. >> >> There are also a few minor patches, see the attachments. >> >> Cheers, >> Orson >> >> On 02/16/2017 07:01 AM, John Beard wrote: >>> Hi, >>> >>> Here is a branch with a set of patches to add the ability to set the >>> grid line/dot size and the minimum grid spacing (to avoid very dense >>> grids when using thicker lines). >>> >>> https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/grid_dot_size >>> >>> This also includes moving the grid display settings our of the Set >>> Grid dialog in to the Display Preferences dialog. As an item in the >>> Dimensions menu, Set Grid isn't really a suitable place, especially as >>> there are now more options. >>> >>> This was a fairly annoying change to make in the code, as the current >>> GAL properties structure was only consumed by the OpenGL GAL canvas. >>> However, now, all GAL canvases have access to it, which opens the way >>> for more display options to be added easily (though if the Display >>> Options dialog gets more options, we might need to put some tabs in, >>> like Eeschema). >>> >>> There are also some supporting infrastructure changes: >>> >>> * A class to bind a text entry and spin buttons together without a lot >>> of verbose repeating of event bindings. >>> * Utility functions to use a mapping table to decouple internal enum >>> values from the values written into config files and radio button >>> selections >>> * Over-visible header causing slow recompilation, hidden a bit better >>> >>> Cheers, >>> >>> John >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
