On Mon, Feb 13, 2017 at 07:08:43PM -0500, Chris Pavlina wrote: > On Mon, Feb 13, 2017 at 06:57:07PM -0500, Wayne Stambaugh wrote: > > Chris, > > > > I had a chance to review the new footprint selector. I like it so far > > although it does seem a bit cramped with both preview window. I'm not > > sure there is much you can do about that. I'm fine with you pushing > > what you have done so far. > > I am going to play with the dialog layout a bit more. The default layout > does feel cramped, but I think I can fix that. > > I'm not going to push it immediately. I realized that when working with > the default kicad libs, it takes much longer to load now, and I like to > be able to pop it up very quickly when putting a schematic together. > Going to take some time to investigate what is slowing things down.
Update: I'm going to push this tonight after cleaning up what remains to be cleaned up, in spite of the performance hit. I've narrowed down what the performance hit is: populating wxTreeListCtrl in the way the previous wxTreeCtrl was populated is just dog slow. I think it may be traversing the list several times for each insertion. I'll probably have to rewrite that bit, but it's not enough of a performance hit to sacrifice having other people's testing eyeballs on it. If anyone else wants to look, the relevant section is COMPONENT_TREE_SEARCH_CONTAINER::UpdateSearchTerm(), which takes a hefty fraction of a second after a naive replacement of wxTreeCtrl with wxTreeListCtrl. > > > > > I do have one comment. It it necessary to open the symbol viewer on a > > left click in the symbol panel? My initial instinct was to click on the > > panel to set the focus to zoom and/or pan the symbol in the panel to get > > a better view. Maybe launching the symbol viewer should occur on a > > double click. Just food for thought. > > I still have to fix the event binding, which got a bit messed up when I > switched tree list control types. I meant to have that done by now but > got sidetracked. Again, won't push until that's done. It shouldn't be > bound to left-click. > > > > > I didn't get a chance to review the code but one thing I want to make > > sure is that you are not adding UI code to any of the symbol or > > footprint library objects. The recent progress dialog patch added UI > > code to the PART_LIBS object. We (I) spent a lot of time uncoupling the > > symbol library code from all things UI and now that has been undone. > > I'll fix this when I implement the symbol library table. > > Nope, nothing added to data objects, the UI code is in UI classes only. > Apologies for pushing the progress dialog patch then - I didn't notice > it did that. Looking at it now, I should have rejected it in this state. > > > > > Cheers, > > > > Wayne > > > > On 2/11/2017 9:07 PM, Chris Pavlina wrote: > > > And, it's in the branch now, temporarily gated by build option > > > KICAD_FOOTPRINT_SELECTOR. At the moment it is VERY rudimentary, by which > > > I mean it doesn't work - the preview is stuck showing one particular > > > footprint permanently, and it's one you probably don't have in your > > > libraries... > > > > > > Hopefully this will be fixed tomorrow. Wayne, my current goal is this: > > > tomorrow, I will have footprint preview working completely, but still no > > > footprint *selection*. At this point, I'd really like to push what I > > > have, so that the footprint preview and the other GUI improvements in > > > the component selector get further testing. Then, I will work on adding > > > footprint selection, followed by 3D preview, both of which can be merged > > > as separate patches. Have you had a chance to review yet? > > > > > > On Sat, Feb 11, 2017 at 08:12:17PM -0500, Chris Pavlina wrote: > > >> This bit is not in the branch yet, but here's a little preview... > > >> > > >> https://misc.c4757p.com/i-can-footprint.png > > >> > > >> Thanks Tom! > > >> > > >> On Mon, Feb 06, 2017 at 09:07:16PM -0500, Chris Pavlina wrote: > > >>> Preview at [email protected]:cpavlina/kicad branch componentchooser. > > >>> Footprint part still pending. > > >>> > > >>> On Sun, Feb 05, 2017 at 09:52:03PM -0500, Chris Pavlina wrote: > > >>>> Still very early... I call it "componentchoosernew" > > >>>> > > >>>> https://misc.c4757p.com/componentchoosernew.png > > >>>> > > >>>> -- > > >>>> Chris > > > > > > _______________________________________________ > > > Mailing list: https://launchpad.net/~kicad-developers > > > Post to : [email protected] > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > More help : https://help.launchpad.net/ListHelp > > > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : [email protected] > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
