Hi Jon, I have just tested the patch, and I really like it. I just need to test it a bit longer, as there are numerous changes, but I am in favor of merging the patch.
I also applied one more patch changing a few defines (UNSPECIFIED, BLACK, WHITE) to static consts, I hope you do not mind. If there are other people interested in testing, I have rebased the changes [1] on the current master. There are also a few minor code formatting fixes. Regards, Orson 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/colors On 02/18/2017 09:24 PM, Jon Evans wrote: > Hi all, > > Attached is a follow-up patch to the COLOR4D change above -- I reverted > from using wxColourPickerCtrl back to wxBitmapButton in the eeschema color > config, because I finally got my Windows 10 testing environment set up, and > found out that for some reason wxColourPickerCtrl looks really ugly in > Windows 10. > > Best, > Jon > > On Fri, Feb 10, 2017 at 8:43 PM, Jon Evans <[email protected]> wrote: > >> Hi all, >> >> Attached is a (rather large!) patch that changes the internal color >> representation to COLOR4D across the codebase (except for places that >> directly deal with wx, where wxColour is used). >> >> This patch also enables arbitrary color selection for schematic and symbol >> library editor, as well as pcbnew in the GAL canvas. GerbView and pcbnew >> legacy canvas still use the old color picker. Colors will be coerced into >> the legacy palette when switching from GAL to legacy, in a way that tries >> to preserve the hue and value. >> >> Colors are serialized to the settings in CSS format, because it supports >> alpha and represents color components the same way COLOR4D does (as >> floating-point values from 0 to 1) >> >> Tested on Linux. Can't test on Windows or Mac yet, sorry. >> I realize this is a large changeset and might take a while to review, so >> just ping me if it stops applying on master and I'll update it. >> >> Best, >> Jon >> > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
