Hi Jon, I really like the generic approach in the zoom methods. This part I would merge instantly, but there is an issue with caching the board bounding box. It does not take into account that items already added to board may change their position and affect the bounding box. I would remove caching completely, what do you think?
If you are going to modify the patch, would you rename boardBBox in COMMON_TOOLS::ZoomFitScreen() to bbox or anything that is not related to board? Thank you in advance. Regards, Orson On 02/23/2017 05:34 AM, Jon Evans wrote: > Hi all, > > This patch finishes off the refactor I did a few days ago, by enabling > ZoomFitScreen to work without knowledge of the BOARD class. > > In order to make this work, I changed the way GetBoundingBox and > ComputeBoundingBox work so that the call sites of GetBoundingBox don't have > to also call ComputeBoundingBox if they don't need to use the > aBoardEdgesOnly flag. > > Those with good knowledge of BOARD should review this to make sure I caught > all the instances where we should mark the bounding box as needing to be > re-computed. > > Best, > Jon > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
