Looks like it should cause breakage, please don't merge. I'll have a look at this later - wx 3.1 is unsupported, but it should be relatively easy to resolve this and reduce future breakage if we ever upgrade.
Could you please file a bug report? On Sun, Apr 02, 2017 at 04:08:32PM +0200, Bernhard Stegmaier wrote: > Hi, > > KiCad doesn’t build (at least for me on OSX) with a current wxWidgets master, > I guess it won’t since wxWidgets change [1] and new component selector. > > Attached is a patch for a workaround/fix which makes compiler happy again and > doesn’t seem to brake anything obvious in the new component selector. > It probably won’t handle all versions of wxWidgets master correctly, because > [1] was done ~4 weeks after 3.1.0 was released. > > The ugly version check could be avoided if just always using the default > constructor, but I don’t know the impact… > > > Regards, > Bernhard > > [1] > https://github.com/wxWidgets/wxWidgets/commit/98294467553fe4dd766419c4e5aa6bc9502d65c7 > > <https://github.com/wxWidgets/wxWidgets/commit/98294467553fe4dd766419c4e5aa6bc9502d65c7> > > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
