Orson, FYI, Alejandro's patch was created before commit a208ba6566e1 which fixed an issue with free text rotation angles. Did that fixed get rolled into the eagle common code?
Cheers, Wayne On 5/8/2017 5:09 AM, Maciej Sumiński wrote: > Hi Alejandro, > > I am really sorry it has taken me so long to review the patch. I have > tested it and it seems to work correctly, so now it is merged. > > I like the refactor changes, good job! I am also aware of the branch > containing initial work on Eagle schematic import, but it has to wait to > be more complete. > > Cheers, > Orson > > On 04/07/2017 02:13 PM, Alejandro Garcia Montoro wrote: >> Hi all, >> >> I'm working in the eeschema plugin for importing Eagle schematics :) >> >> I've decided to reuse the good work done in pcbnew, so this patch moves the >> XML parsing logic from there to common. >> >> It also replaces Boost.PropertyTree to wxXml to help a little bit with our >> quest against boost. >> >> I've tested some boards and the output of the plugin with the current logic >> and with this patch applied is exactly the same, but more tests are more >> than welcome. >> >> Hope this is useful. >> >> Best, >> Alejandro >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
