|
Thanks for the quick patch Wayne. I'm focused on software dev right now, but will test when I can
free up some cycles.
Regards
David Godfrey SB Tech Services mb: +61 437 286 200 chat:
with dcg_mx at
#sbts:matrix.org (Computer) #sbts:matrix.org (mobile Device) On 29/09/17 01:14, Wayne Stambaugh
wrote:
I recant my original position that it would not be a trivial fix. I just pushed the fix to the master branch. Please test it and let me know if you find any issues. I will be out of town over the weekend so I may not reply as quickly as I normally do.Please note that this fix isn't ideal. Since Pcbnew does not support odd numbered copper layers, selecting front or back layer only configuration in the layer select dialog will not remove objects from the copper layers. It will remove them from all other layers if they are not part of a footprint. Even though this isn't technically correct, it will (should?) prevent any false positive DRC tests from occurring because objects will only exist on layers that exist. Keep in mind that this operation cannot be undone so once you save the board after removing layers, that information is lost. If you are not sure about the change, don't save the board. I will now resume my previously scheduled symbol library table work. Cheers, Wayne On 9/28/2017 3:18 AM, Kristoffer Ödmark wrote:I agree as well, I've been hit by this bug once. And it was enough. I was actually planning to try and fix it similar to the way you are proposing right after the copypasta thingy is done. ( My ideal solution would be to add a "remove items on extra layers" button to the dialog that would become enabled when removing layers, and simultaneously disbling the OK button, and only by pressing that would the OK button become enabled. ) On 09/28/2017 01:32 AM, David Godfrey wrote:Hi Wayne, I'll back you on this decision. It's more than once cost both time and money, to say nothing of frustration to multiple users. Personally, I've not been caught with sending a board to production in this state, but I certainly have run into the problem and caught it during routing (Obviously non connected pins that don't DRC) If a layer is deleted, it's deleted, there simply shouldn't be any leftovers of any description. A clear warning that this is happening and confirmation dialog is really all that is needed, especially if that dialog explicitly lists the layers that are being removed. On 27/09/17 22:08, Wayne Stambaugh wrote:This bug[1] has reared it's ugly head again so I am going to fix it once and for all before the stable 5 release. We cannot continue storing objects on deleted layers in the board file which cause the DRC to pass connection tests when in reality there are failures. I don't really have the time so you should assume that this is going push back the release. It probably should be backported to the stable release but given the code deviations, I don't see that happening unless someone else feels motivated to do so. I looked at the existing code and it's not going to be a trivial fix. I do not intend to do anything fancy such as give the user the option to merge objects from deleted layers to other layers. I'm going to keep it simple by just warning the user and removing all objects from the removed layers. This includes non-copper layers as well. I don't see how keeping objects on layers that don't exist in the board is valid. I'm not really asking for comments but if you have any suggestions outside what I have presented I am willing to entertain them. [1]: https://bugs.launchpad.net/kicad/+bug/893950 _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelpRegards David Godfrey SB Tech Services mb: +61 437 286 200 <tel:+61437286200> _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp |
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
