On 10/19/2017 04:32 PM, jp charras wrote: [snip] > Hi Orson, > > Could you have a look into this patch? > It fixes the issue when a change is committed with a item belonging a > footprint. > > But I do not have very good knowledge of COMMIT classes.
Hi Jean-Pierre, Thank you for looking into the problem. In the proposed patch BOARD_COMMIT will try to save the item parent even for items that do not belong to modules (e.g. tracks, vias), ending up with the whole board stored in the undo buffer. I would rather take advantage of BOARD_COMMIT::m_editModules field to determine whether the commit is created by the footprint editor. Then the check should be valid, but still the code needs to be tested to be sure it works as expected. If you can wait, I can wrap up a fix by tomorrow morning. Regards, Orson
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
