This is one more thing to fix. I have successfully imported a schematic sheet with non-ASCII texts, but this project uses symbols named using non-ASCII characters and this is not yet handled.
On 12/08/2017 03:13 PM, Wayne Stambaugh wrote: > I'm guessing we can also mark this bug report > https://bugs.launchpad.net/kicad/+bug/1736083 as fix committed. > > On 12/08/2017 08:50 AM, Maciej Sumiński wrote: >> Hi Wayne, >> >> I have tested it and indeed it fixes the problem with Eagle import as well. >> >> Cheers, >> Orson >> >> On 12/08/2017 02:42 PM, Wayne Stambaugh wrote: >>> Orson, >>> >>> Did you test this with any eagle projects that contain non-ascii >>> characters before pushing this patch? >>> >>> Cheers, >>> >>> Wayne >>> >>> On 12/08/2017 08:38 AM, Maciej Sumiński wrote: >>>> Hi Jean-Pierre, >>>> >>>> Thank you for the fix, I think you are right. I applied the patch to the >>>> master branch. >>>> >>>> Regards, >>>> Orson >>>> >>>> On 12/08/2017 01:53 PM, jp charras wrote: >>>>> Hi Orson >>>>> >>>>> Could you have a look into this patch. >>>>> >>>>> I am thinking it is also a fix for bug 1737143. >>>>> >>>>> Currently our UTF8 class has only a append operator for ASCII7 chars. >>>>> But if the code uses something like (it is accepted by the compiler): >>>>> my_utf_8_string += mychar; >>>>> and if mychar is a int (or a wchar_t) containing a non ASCII7 value, the >>>>> UTF8 string is broken. >>>>> the patch adds a append operator for non ASCII7 value (wchar_t wide chars) >>>>> >>>>> >>>>> I am pretty sure this kind of issues also exists in eagle import (when >>>>> eagle files uses non ASCII7 >>>>> chars in texts). >>>>> >>>>> Thanks. >>>>> >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : kicad-developers@lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp