I'm I safe in assuming that both of these patches are ready to be merged or is more testing required?
On 12/15/2017 12:19 PM, Jeff Young wrote: > Hi Seth, > > Yep, works fine for tap and double-tap on OSX. > > Cheers, > Jeff. > >> On 15 Dec 2017, at 16:29, Seth Hillbrand <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi Jeff- >> >> Here is the patch from the original e-mail. >> >> Best- >> Seth >> >> On Fri, Dec 15, 2017 at 3:35 AM, Jeff Young <[email protected] >> <mailto:[email protected]>> wrote: >> >> Where can I find the patch (it wasn’t linked to either bug report >> mentioned)? >> >> I want to make sure it doesn’t break trackpad double-tapping. >> >> Speaking of which, tapping in general is broken in GAL >> (see https://bugs.launchpad.net/kicad/+bug/1737010 >> <https://bugs.launchpad.net/kicad/+bug/1737010>). I submitted a >> patch with that bug; any chance we can get it merged along with this? >> >> Thanks, >> Jeff >> >> >>> On 15 Dec 2017, at 04:29, Seth Hillbrand >>> <[email protected] <mailto:[email protected]>> wrote: >>> >>> Thanks Chris and Orson for testing. As long as everyone is OK >>> with the approach, I'm happy to build a second patch to extend >>> this to the GAL canvas. Does anyone have objections to how this >>> functions in legacy for now? >>> >>> Best- >>> Seth >>> >>> On Mon, Dec 11, 2017 at 5:02 AM, Maciej Sumiński >>> <[email protected] <mailto:[email protected]>> wrote: >>> >>> I tested the patch on Linux and it works as advertised. Well >>> done, we >>> need the same thing for GAL too. >>> >>> Cheers, >>> Orson >>> >>> On 12/06/2017 07:05 PM, Seth Hillbrand wrote: >>> > The attached patch fixes >>> https://bugs.launchpad.net/kicad/+bug/1154020 >>> <https://bugs.launchpad.net/kicad/+bug/1154020> >>> > >>> > The current double-click handler in draw_panel gets >>> overridden by the >>> > disambiguation menu, preventing double-clicks from being >>> properly handled. >>> > This patch introduces a delay between the mouse up and >>> handling the >>> > single-click. If the double-click arrives in this time, >>> the double-click >>> > is handled. Otherwise, the normal single-click is processed. >>> > >>> > Of note, we only introduce this delay in cases where the >>> disambiguation >>> > menu is needed. Otherwise, single-clicks are immediately >>> processed. >>> > >>> > Tested on MacOS and Linux. The current delay is set to >>> 250ms. We might >>> > slow this down to 400-500ms but that felt a bit clunky to me. >>> > >>> > -Seth >>> > >>> > >>> > >>> > _______________________________________________ >>> > Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> > Post to : [email protected] >>> <mailto:[email protected]> >>> > Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> > More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>> > >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> Post to : [email protected] >>> <mailto:[email protected]> >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> Post to : [email protected] >>> <mailto:[email protected]> >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >> >> >> <0001-wx-Add-double-click-handling-in-disambiguation-cases.patch> > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
