Hey Dan, On 01/04/2018 03:34 PM, Dan Weatherill wrote: > Wayne, > d'oh! OK, I have added the check in attached patch. We could avoid a string > copy with some extra work, but I feel it's unnecessary for a filename.
Cross platform issues are always easy to miss. I merged your patch. Thank you for your contribution to KiCad. > > Incidentally, I see a few memory leaks etc in here that could be fixed with > unique_ptr usage. Is kicad now requiring c++11 and is this the kind of thing > that is acceptable in a patch? We officially been a c++11 project for quite a while now so unique_ptr is way to go. Cheers, Wayne > > THanks, > Dan W > > On Thursday, 4 January 2018 20:02:10 GMT Wayne Stambaugh wrote: >> Dan, >> >> Please make this case insensitive. Otherwise on case sensitive >> platforms where someone has decided to use .Wbk, .WBK, etc. for the file >> extension, your code doesn't add .wbk. >> >> Thanks, >> >> Wayne >> >> On 01/04/2018 02:37 PM, Dan Weatherill wrote: >>> Hi, >>> at present, the simulator dialog saves workbook files without checking >>> extensions, but only opens workbook files that have the .wbk extension. >>> This makes it very easy to save files and not be able to open them >>> (without some minor frustration). The attached patch checks the extension >>> in the save file dialog and adds it if not present. >>> >>> This is intended as a very gentle attempt to start contributing to kicad, >>> and seeing if I have the patch format / commit messages etc correct. >>> >>> Many thanks, >>> Dan W >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
