I have just tested the patch on a Windows virtual machine where KiCad normally crashed and it seems that the fallback mechanism works as it should.
Chris, if you have time, please check it on you hardware too, if not - I will just push the patch to the master branch. I vaguely recall that Linux without OpenGL support might crash even before KiCad has a chance to throw an exception (X.Org error). Perhaps this case could be resolved with Jon's patch. Cheers, Orson On 01/17/2018 04:30 PM, Maciej Sumiński wrote: > An alternative approach attached. Perhaps the two patches could be > combined for extra safety. > > Cheers, > Orson > > On 01/16/2018 08:15 PM, Maciej Suminski wrote: >> For me - not entirely, but definitely it is better than the current >> implementation. If you run KiCad for the first time and select 'Enable >> hardware acceleration' on a machine that does not support OpenGL, it >> switches to Cairo (correctly). Then, when you turn off KiCad, it will >> save OpenGL as the default canvas and you will not be able to run pcbnew >> again until you manually modify the configuration files (or remove them). >> >> I will have another trial at fixing the problem, finally I have an >> environment where I can test different solutions. >> >> Cheers, >> Orson >> >> On 01/16/2018 07:04 PM, Chris Pavlina wrote: >>> Yes! You got it, works for me :) >>> >>> On Tue, Jan 16, 2018 at 05:16:57PM +0000, Chris Pavlina wrote: >>>> Sorry I disappeared for a while. I'm building on the machine where I >>>> experienced the bug right now. >>>> >>>> On Tue, Jan 16, 2018 at 04:26:16PM +0000, Jon Evans wrote: >>>>> Wayne/Orson, I'm not sure Chris will have time to review this, could you >>>>> please take a look? >>>>> >>>>> Thanks, >>>>> Jon >>>>> >>>>> On Thu, Jan 11, 2018 at 11:02 PM, Jon Evans <j...@craftyjon.com> wrote: >>>>> >>>>>> Updated patch attached (missed initializers in the original) >>>>>> >>>>>> On Wed, Jan 10, 2018 at 11:40 PM, Jon Evans <j...@craftyjon.com> wrote: >>>>>> >>>>>>> Hopefully this fixes: >>>>>>> https://bugs.launchpad.net/kicad/+bug/1741787 >>>>>>> although I don't currently have a good way of reproducing the crash. >>>>>>> >>>>>>> Chris, if you can give it a try on your crashing machine that would be >>>>>>> greatly appreciated. >>>>>>> >>>>>>> Thanks >>>>>>> -Jon >>>>>>> >>>>>> >>>>>> >>>> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp