Sorry; user error. (I had started a build before noticing I was on master. After switching to kicad/macos-wx-3.0 I re-ran “configure”, but forgot to do a “make clean”.)
> On 20 Jan 2018, at 13:50, Bernhard Stegmaier <[email protected]> wrote: > > Hi Jeff, > > that’s what I use: > > ../wxWidgets-KiCad/configure > --prefix=/Volumes/OSXData/bstegmaier/KiCad/wx-3.0 --with-opengl --enable-aui > --enable-utf8 --enable-html --enable-stl --with-libjpeg=builtin > --with-libpng=builtin --with-regex=builtin --with-libtiff=builtin > --with-zlib=builtin --with-expat=builtin --without-liblzma > --with-macosx-version-min=10.12 --enable-macosx_arch=x86_64 CC=clang > CXX=clang++ > > Seems to be pretty identical. > The —enable-universal-binary is different… is this correct? > > Wrt .gitignore: > Yes, I didn’t create one. > I don’t know if there is one, didn’t look for it. > I usually build in parallel folder, so I don’t have any compile things in > source folder. > > > Regards, > Bernhard > >> On 20. Jan 2018, at 14:43, Jeff Young <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi Bernhard, >> >> Could you share the config command you used to set up wxWidgets? I used: >> >> ../configure \ >> --prefix=`pwd`/../wx-bin \ >> --with-opengl \ >> --enable-aui \ >> --enable-utf8 \ >> --enable-html \ >> --enable-stl \ >> --enable-debug \ >> --enable-debug-gdb \ >> --with-libjpeg=builtin \ >> --with-libpng=builtin \ >> --with-regex=builtin \ >> --with-libtiff=builtin \ >> --with-zlib=builtin \ >> --with-expat=builtin \ >> --without-liblzma \ >> --with-macosx-version-min=10.13 \ >> --enable-universal-binary=x86_64 \ >> CC=clang \ >> CXX=clang++ >> >> but I’m getting a make error: >> >> make: *** No rule to make target `../include/wx/osx/cocoa/stdpaths.h', >> needed by `basedll_appbase.o'. Stop. >> >> I assume I’m on the right branch: >> >> Jeffs-MBP:build jeff$ git status >> On branch kicad/macos-wx-3.0 >> Your branch is up-to-date with 'origin/kicad/macos-wx-3.0’. >> >> Thanks, >> Jeff. >> >> PS: I also seem to be missing a .gitignore file. Is that not in yet, or is >> that a symptom of something else? >> >> >>> On 19 Jan 2018, at 16:49, Bernhard Stegmaier <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Hi, >>> >>>> On 15. Jan 2018, at 10:39, Carsten Schoenert <[email protected] >>>> <mailto:[email protected]>> wrote: >>>>> >>>>> We should make it obvious that it is a branch of wxwidgets for kicad >>>>> specifically patched for macos to avoid any confusion. >>>> based on my experiences in other projects I suggest to use topic and >>>> prefixed branch names. I'd avoid the usage of capital letters. >>>> >>>> e.g. >>>> kicad/macos-10 >>>> kicad/macos-11 >>>> kicad/wx-3.0.3 >>> >>> Good proposal, I like that. >>> So, I created a branch >>> >>> kicad/macos-wx-3.0 >>> >>> based on the original WX_3_0_BRANCH. >>> If at some point patches for other OS (e.g., the mingw patches) should go >>> in, we can still rename it and remove the macOS part. >>> >>>>> 2) Commits >>>>> The branch should always be rebased to wxWidgets changes, so all >>>>> patches will stay at the top. >>>> Rethink about rebasing to hold the branches in sync with upstream as >>>> this breaks clones of your branches due smashed SHA IDs and people would >>>> need to do a hard reset. Just merge any upstream changes as usual into >>>> your branches, in case you want to address / forward your work to >>>> upstream you also would do a merge request then. That's the typicall >>>> workflow I know in such cases. >>> >>> Thanks for the reminder, I tend to forget that. >>> So, no rebasing but merging. >>> >>>>> I still find it somehow difficult to see where original branch ends >>>>> and own changes start.> Should we add some prefix “KiCad: …” to all >>>>> commit messages? >>>> >>>> I see no need to do so as you work on "your" branch and merge commits >>>> are visible as that they are, I personally do some prefixing in my work >>>> in the subject for the file, component, part, OS (...) the commit is about. >>> >>> I decided to prefix every change with “macOS: “, just in case the branch >>> gets used for other OS in future. >>> >>> >>> I reviewed all the patches and only applied what was still needed/valid. >>> See end of the mail for details. >>> For me, it compiles on macOS 10.12 and 10.13 (with macosx-version-min from >>> 10.13 down to 10.7). >>> >>> The branch should be ready to use now. >>> All macOS devs please test if you see any problems or if anything is >>> missing. >>> >>> As soon as Adam has integrated it into the daily builds also the current >>> build errors should be gone. >>> >>> Next step would be to adapt KiCad compile documentation and to remove the >>> patches from KiCad source. >>> @Wayne: Is it OK for you to remove the patches? >>> >>> >>> Regards, >>> Bernhard >>> >>> ===== >>> >>> Patches applied as in KiCad repository: >>> wxwidgets-3.0.0_macosx.patch >>> wxwidgets-3.0.0_macosx_bug_15908.patch >>> wxwidgets-3.0.0_macosx_staticbox_tabbing.patch >>> wxwidgets-3.0.2_macosx_magnify_event.patch >>> wxwidgets-3.0.2_macosx_retina_opengl.patch >>> >>> Applied with changes: >>> wxwidgets-3.0.0_macosx_soname.patch >>> ==> See wxWidget ticket >>> wxwidgets-3.0.2_macosx_data_view_ctrl.patch >>> ==> See wxWidget ticket, changed to strip out styles in question >>> wxwidgets-3.0.2_macosx_quasimodal.patch >>> ==> Corrected version with missing header >>> >>> No longer needed (already applied or other fix): >>> wxwidgets-3.0.0_macosx_scrolledwindow.patch >>> wxwidgets-3.0.2_macosx_unicode_pasteboard.patch >>> wxwidgets-3.0.2_macosx_high_sierra.patch >>> wxwidgets-3.0.2_macosx_sierra.patch >>> wxwidgets-3.0.2_macosx_yosemite.patch >>> >>> Additional patches (not yet in KiCad repository) >>> https://bugs.launchpad.net/kicad/+bug/1692352 >>> <https://bugs.launchpad.net/kicad/+bug/1692352> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> Post to : [email protected] >>> <mailto:[email protected]> >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >> >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
