Hi Bernhard, All good questions. The 8 just lines it up with the label text above the box. Seems like 5 should have worked, since that’s used all over the place, but it didn’t.
I tried setting up a constraint to peg it to whatever margin was there, but it had no effect. I suspect this is why it looks different on OSX: the wxWidgets team got tired of banging their head on it and gave up. (I can sympathise.) On the larger issue, at this point I think we should consider wxWidgets as adopted (ie: as our own code). The wxWidgets team isn’t too interested in 3.x, and 4.x is going to be (would be?) a big enough re-write that we’re probably not going to want to (or be able to) carry any changes forward anyway. That doesn’t directly answer the question of how much we should change; just that I don’t think we should treat stuff under the wxWidgets API terribly differently to the stuff above it (ie: Kicad proper). Cheers, Jeff. > On 23 Jan 2018, at 22:51, Bernhard Stegmaier <stegma...@sw-systems.de> wrote: > > Thanks, Jeff. > > So, this brings up a very general question: > How far do we want to go with patching wxWidgets in our fork? > > Don’t get me wrong… the patch looks sane and I guess it then will look on > macOS like it does on Linux/Windows - for whatever reason (bug, intended?) it > didn’t look like that before. > Opinions? > Wayne? > > From a pure user perspective I guess it would be more important to have it > look/behave the same on all platforms (as long as it doesn’t break OS > specific GUI stuff). > So, I am not opposed to apply such patches and all that might come in > future... > > > Regards, > Bernhard > >> On 23. Jan 2018, at 22:30, Jeff Young <j...@rokeby.ie >> <mailto:j...@rokeby.ie>> wrote: >> >> Thanks, Bernhard. I tried that, but it didn’t help. >> >> I ended up taking out a pretty big hammer: I overrode the setFrameOrigin >> method for radioButtons. When radio buttons are created in a >> column-oriented radio box, they now get a wxLEFT style. The setFrameOrigin >> override bangs the x value back to 8 if that flag is set. >> >> Patch in https://bugs.launchpad.net/kicad/+bug/1745026 >> <https://bugs.launchpad.net/kicad/+bug/1745026>. >> >> Cheers, >> Jeff. >> >> >>> On 23 Jan 2018, at 16:24, Bernhard Stegmaier <stegma...@sw-systems.de >>> <mailto:stegma...@sw-systems.de>> wrote: >>> >>> In wxWidgets master there are a couple of alignment fixes like this one: >>> >>> https://github.com/wxWidgets/wxWidgets/commit/5aa66ffd936d00d101f12d6e8305a0d2f6c82cc2#diff-4c33f04f2d98bef24c5f526f6fa79d33 >>> >>> <https://github.com/wxWidgets/wxWidgets/commit/5aa66ffd936d00d101f12d6e8305a0d2f6c82cc2#diff-4c33f04f2d98bef24c5f526f6fa79d33> >>> >>> I don’t know if some of them fix that problem. >>> My last wxWidgets master build shows the same behaviour but I don’t know >>> for sure if those fixes were already in. >>> >>> >>> Regards, >>> Bernhard >>> >>>> On 23. Jan 2018, at 15:40, Jeff Young <j...@rokeby.ie >>>> <mailto:j...@rokeby.ie>> wrote: >>>> >>>> Yeah, it’s just most noticeable in Read Netlist, but in fact it’s all >>>> radio buttons in a box sizer: >>>> >>>> <PastedGraphic-2.png> >>>> >>>>> On 23 Jan 2018, at 14:35, Jeff Young <j...@rokeby.ie >>>>> <mailto:j...@rokeby.ie>> wrote: >>>>> >>>>> Note: I’ve split the dialog issues out into a separate thread. >>>>> >>>>> Hi Wayne, >>>>> >>>>> It still happens. I have wxFormBuilder running, but none of the settings >>>>> affect the centering. I suspect it’s just how the wxWidgets team >>>>> implemented it on OSX. >>>>> >>>>> I might light at it again while putting my flame-suit on over Undo. ;) >>>>> >>>>> Cheers, >>>>> Jeff. >>>>> >>>>> >>>>>> On 23 Jan 2018, at 14:19, Wayne Stambaugh <stambau...@gmail.com >>>>>> <mailto:stambau...@gmail.com>> wrote: >>>>>> >>>>>> Jeff, >>>>>> >>>>>> Is this still an issue. This dialog looks fine on windows and linux so >>>>>> I have no way of confirming that any changes to the wxformbuilder >>>>>> settings would fix it. Any of our macos devs have wxformbuilder on >>>>>> their system so they can fix this? >>>>>> >>>>>> Cheers, >>>>>> >>>>>> Wayne >>>>>> >>>>>> On 1/18/2018 1:17 PM, Jeff Young wrote: >>>>>>> It’s not center vs. left alignment, but rather that the radio button >>>>>>> group is centered within the staticTextBox. Note in particular the >>>>>>> alignment of the two radio button groups in the left column: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> On 18 Jan 2018, at 17:23, Nick Østergaard <oe.n...@gmail.com >>>>>>>> <mailto:oe.n...@gmail.com> >>>>>>>> <mailto:oe.n...@gmail.com <mailto:oe.n...@gmail.com>>> wrote: >>>>>>>> >>>>>>>> What do you mean by centered? I don't see anything centered, I just >>>>>>>> see them left aligned. Looks ok to me unless I am looking at the wrong >>>>>>>> thing. >>>>>>>> >>>>>>>> 2018-01-14 <tel:20%2018%2001%2014 <tel:20%2018%2001%2014>> 0:02 >>>>>>>> GMT+01:00 Jeff Young >>>>>>>> <j...@rokeby.ie <mailto:j...@rokeby.ie> <mailto:j...@rokeby.ie >>>>>>>> <mailto:j...@rokeby.ie>>>: >>>>>>>> >>>>>>>> This is a shortcut for eeschema Annotate + eeschema Write Netlist >>>>>>>> + pcbnew Read Netlist, right? >>>>>>>> >>>>>>>> Is there a reason the Update PCB from Schematic dialog doesn’t >>>>>>>> include the “keep/delete” options we have in the Read Netlist dialog? >>>>>>>> >>>>>>>> (It appears to mostly do a delete, but not >>>>>>>> entirely: https://bugs.launchpad.net/kicad/+bug/1682970 >>>>>>>> <https://bugs.launchpad.net/kicad/+bug/1682970> >>>>>>>> <https://bugs.launchpad.net/kicad/+bug/1682970 >>>>>>>> <https://bugs.launchpad.net/kicad/+bug/1682970>> ) >>>>>>>> >>>>>>>> (Are the Read Netlist dialog radio buttons really meant to be >>>>>>>> centered? They look distinctly odd.) >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>>> <https://launchpad.net/~kicad-developers> >>>>>>>> <https://launchpad.net/~kicad-developers >>>>>>>> <https://launchpad.net/~kicad-developers>> >>>>>>>> Post to : kicad-developers@lists.launchpad.net >>>>>>>> <mailto:kicad-developers@lists.launchpad.net> >>>>>>>> <mailto:kicad-developers@lists.launchpad.net >>>>>>>> <mailto:kicad-developers@lists.launchpad.net>> >>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>>> <https://launchpad.net/~kicad-developers> >>>>>>>> <https://launchpad.net/~kicad-developers >>>>>>>> <https://launchpad.net/~kicad-developers>> >>>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>>> <https://help.launchpad.net/ListHelp> >>>>>>>> <https://help.launchpad.net/ListHelp >>>>>>>> <https://help.launchpad.net/ListHelp>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>> <https://launchpad.net/~kicad-developers> >>>>>>> Post to : kicad-developers@lists.launchpad.net >>>>>>> <mailto:kicad-developers@lists.launchpad.net> >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>> <https://launchpad.net/~kicad-developers> >>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>> <https://help.launchpad.net/ListHelp> >>>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>> <https://launchpad.net/~kicad-developers> >>>>>> Post to : kicad-developers@lists.launchpad.net >>>>>> <mailto:kicad-developers@lists.launchpad.net> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>> <https://launchpad.net/~kicad-developers> >>>>>> More help : https://help.launchpad.net/ListHelp >>>>>> <https://help.launchpad.net/ListHelp> >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> <https://launchpad.net/~kicad-developers> >>>>> Post to : kicad-developers@lists.launchpad.net >>>>> <mailto:kicad-developers@lists.launchpad.net> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> <https://launchpad.net/~kicad-developers> >>>>> More help : https://help.launchpad.net/ListHelp >>>>> <https://help.launchpad.net/ListHelp> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> <https://launchpad.net/~kicad-developers> >>>> Post to : kicad-developers@lists.launchpad.net >>>> <mailto:kicad-developers@lists.launchpad.net> >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> <https://launchpad.net/~kicad-developers> >>>> More help : https://help.launchpad.net/ListHelp >>>> <https://help.launchpad.net/ListHelp> >>> >> >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
