Updated patch. On Tue, Feb 13, 2018 at 9:41 AM Wayne Stambaugh <stambau...@gmail.com> wrote:
> On 02/12/2018 05:21 PM, Russell Oliver wrote: > > So a file created on disk in the project folder that is then added as a > > path in the project specification? > > Yes. Just set m_PageLayoutDescrFileName to empty.kicad_wks for both the > schematic and the board BASE_SCREEN objects and you should be good to go. > > > > > As a more general concept then should every project have a layout file > > in the project folder? > > Only when the default worksheet cannot be used. If you are OK with the > default worksheet, then no worksheet file is required. > > > > > > > > > On 13 Feb 2018 02:59, "Wayne Stambaugh" <stambau...@gmail.com > > <mailto:stambau...@gmail.com>> wrote: > > > > I prefer adding an empty.kicad_wks file be added to the project and > then > > set the board and schematic worksheets to this file. This would > negate > > the file format rev bumps. > > > > On 2/12/2018 10:48 AM, Maciej Sumiński wrote: > > > Hi Russell, > > > > > > You are right, it adds a special case for project file format, so > > > technically it is a version bump. Alternatively one could simply > > create > > > "empty.kicad_wks" and store there the contents of > > emptyPageLayout[]. It > > > seems safer, but on the other hand I would like to be able to > specify > > > that design uses an empty worksheet layout. > > > > > > Wayne, what do you think? Is it acceptable that we add a reserved > > > keyword "empty" to indicate an empty worksheet layout for a > > project? If > > > so, we need to implement it both for pcbnew and eeschema. > > > > > > Regards, > > > Orson > > > > > > On 02/11/2018 12:24 AM, Russell Oliver wrote: > > >> Hi Orson and Wayne > > >> > > >> I have updated the patch from your changes Orson, so that the > > change is > > >> saved using the project file settings, by setting the schematic > > layout file > > >> path as "empty" eg > > >> PageLayoutDescrFile=empty > > >> > > >> It is technically a file format change, but it also provides the > > option to > > >> those that do not want a border to specify it for a schematic. > > >> > > >> Kind Regards > > >> Russell > > >> > > >> > > >> On Thu, Feb 8, 2018 at 10:25 PM Maciej Sumiński > > <maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch>> > > >> wrote: > > >> > > >>> There is still one problem to be solved here: worksheet layout > > is not > > >>> saved in schematic file, so the default worksheet is restored > > when an > > >>> imported project is saved and reloaded. > > >>> > > >>> I have nothing against the patch, it gives a nicer first > impression. > > >>> > > >>> Cheers, > > >>> Orson > > >>> > > >>> On 02/07/2018 04:44 PM, Wayne Stambaugh wrote: > > >>>> Thanks for testing this. I know I'm being paranoid but we've > > been bit > > >>>> by this before. Maybe someday our unit testing will actually > get > > >>>> implemented. > > >>>> > > >>>> Wayne > > >>>> > > >>>> On 2/7/2018 8:21 AM, Russell Oliver wrote: > > >>>>> I just tested printing then and it worked fine. plus one > person's > > >>>>> unhandled edge case is another's unit test. > > >>>>> > > >>>>> > > >>>>> > > >>>>> On Thu, Feb 8, 2018 at 12:05 AM Wayne Stambaugh > > <stambau...@gmail.com <mailto:stambau...@gmail.com> > > >>>>> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>> > > wrote: > > >>>>> > > >>>>> Be careful with zero length line segments. They have been > > known to > > >>>>> cause issues in the past. We recently fixed a print bug > > where a > > >>> zero > > >>>>> diameter circle was causing pages not to print. > > >>>>> > > >>>>> On 2/7/2018 7:45 AM, Russell Oliver wrote: > > >>>>> > Hi Orson, > > >>>>> > > > >>>>> > I'm completely fine with any simplifications and style > > changes. > > >>>>> > > > >>>>> > With regards to the zero length line, it appears on line > > 110 of > > >>> your > > >>>>> > patch file. > > >>>>> > 110: + "(line (name segm1:Line) (start 0 0) (end 0 > 0))\n" > > >>>>> > > > >>>>> > JP mentions in a comment to the bug report that there is > > a legacy > > >>>>> > compatibility requirement to have at least one item in > > the page > > >>>>> layout, > > >>>>> > otherwise the default layout it used. This was for old > > schematics > > >>> that > > >>>>> > do not have a page layout specified. > > >>>>> > > > >>>>> > Kind Regards > > >>>>> > Russell > > >>>>> > > > >>>>> > > > >>>>> > On Wed, Feb 7, 2018 at 12:13 AM Maciej Sumiński > > >>>>> <maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch> > > <mailto:maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch>> > > >>>>> > <mailto:maciej.sumin...@cern.ch > > <mailto:maciej.sumin...@cern.ch> <mailto:maciej.sumin...@cern.ch > > <mailto:maciej.sumin...@cern.ch> > > >>>>>> > > >>>>> wrote: > > >>>>> > > > >>>>> > Hi Russell, > > >>>>> > > > >>>>> > Thank you very much for the patch. It works as > > expected and I > > >>>>> would like > > >>>>> > to merge it, but there are two things. > > >>>>> > > > >>>>> > I have simplified the patch a bit (moved the empty > > layout to > > >>>>> an existing > > >>>>> > file, minor code formatting fixes), so please > > confirm you are > > >>>>> ok with > > >>>>> > committing it under your name. > > >>>>> > > > >>>>> > Another question is about "there is a 0 length line > > to fool > > >>>>> something > > >>>>> > somewhere." comment for const char emptyLayout[]. > > Could you > > >>> say > > >>>>> > something more about it? I could not spot a 0 length > > line in > > >>>>> the layout > > >>>>> > description, so perhaps we can remove it to avoid > > confusion. > > >>>>> > > > >>>>> > Regards, > > >>>>> > Orson > > >>>>> > > > >>>>> > On 02/03/2018 01:27 AM, Russell Oliver wrote: > > >>>>> > > Attached is a patch that adds an empty layout > > using the same > > >>>>> > method as the > > >>>>> > > SetDefaultLayout function, which is then called by > > the Eagle > > >>>>> schematic > > >>>>> > > plugin to leave only the imported frame visible. > > >>>>> > > > > >>>>> > > https://bugs.launchpad.net/kicad/+bug/1729722 > > <https://bugs.launchpad.net/kicad/+bug/1729722> > > >>>>> > > > > >>>>> > > Kind Regards > > >>>>> > > Russell > > >>>>> > > > > >>>>> > > > > >>>>> > > > > >>>>> > > _______________________________________________ > > >>>>> > > Mailing list: > > https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> > > Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>>>> <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net>> > > >>>>> > <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>>>> <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net>>> > > >>>>> > > Unsubscribe : > > https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> > > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > >>>>> > > > > >>>>> > > > >>>>> > _______________________________________________ > > >>>>> > Mailing list: > > https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> > Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>>>> <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net>> > > >>>>> > <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>>>> <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net>>> > > >>>>> > Unsubscribe : > > https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > >>>>> > > > >>>>> > > > >>>>> > > > >>>>> > _______________________________________________ > > >>>>> > Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> > Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>>>> <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net>> > > >>>>> > Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > >>>>> > > > >>>>> > > >>>>> _______________________________________________ > > >>>>> Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>>>> <mailto:kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net>> > > >>>>> Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>>> More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > >>>>> > > >>>> > > >>>> _______________________________________________ > > >>>> Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>> Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>>> Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>>> More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > >>>> > > >>> > > >>> > > >>> _______________________________________________ > > >>> Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>> Post to : kicad-developers@lists.launchpad.net > > <mailto:kicad-developers@lists.launchpad.net> > > >>> Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > >>> More help : https://help.launchpad.net/Lis > > >>> <https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp>>t Help n > > >>> > > >> > > > > > > > > > > >
0001-Add-empty-eeschema-page-layout-for-Eagle-schematic-i.patch
Description: Binary data
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
