Jose, You are correct. The only regression would be for boards create between the original patch and the bug fix which would be a fairly short period. Other than fixing broken older board files, the rotation feature remains in tact so I don't think any changes are required.
Cheers, Wayne On 2/12/2018 8:37 PM, José Ignacio wrote: > This is a bit of a pet issue. the original patch introduced a regression > (text suddenly got flipped upside down because of the way it was saved > and the way kicad restricted text angles), that later was fixed, but the > fix only worked correctly for files created before the change > (regression) was introduced. Thus the "regression" kevin refers to was > just the restoration of the original behavior for files _from the > previous released version of KiCad_, Using the dev version carries a > small risk of having to manually change your files as kicad can only > really promise to open successfully files from actual released versions > of the software (though in general it has done a pretty damn good job at > keeping continuous compatibility throughout the development of this new > series). > > On Mon, Feb 12, 2018 at 5:01 PM, Marco Ciampa <ciam...@libero.it > <mailto:ciam...@libero.it>> wrote: > > On Mon, Feb 12, 2018 at 02:14:41PM -0500, Kevin Cozens wrote: > > On 2018-02-12 12:52 PM, Wayne Stambaugh wrote: > > >Obviously I did not get the stable 5 branch created over the weekend. > I > > >was busy patch reviewing and merging. > > [snip]> I should be able to get v5 branched this weekend so going > forward we > > >have a few bugs tagged for rc2 which I'm hoping take less than a month > > >to complete. > > > > Text rotation in pcbnew is another item that needs to be looked at > (again). > > I provided a patch to allow R to rotate text to any multiple of 90 > degrees. > > Since the patch was accepted in to the code base some other code change > has > > limited the rotations of text to 0 or 90 degrees once again. Half the > text > > on a PCB of mine is now upside down. > > > > I've been busy on a couple of projects so I haven't yet filed a bug > report > > about this regression. I will file a report asap. > > Hi Kevin, > since it seems to me that it is not the first time I see this kind of > regressions happen to KiCad, I wonder why this happens and also if there > is a way to avoid it, for example a more strict workflow to commit > patches or to do more atomic changes or to use more git rebase instead > of merge and so on ... > > I am _not_ a developer so I might have said something incorrect or naïve > but I am curious and I cannot resist to ask ... sorry for the noise... > > TIA > > Best regards, > > -- > > > Marco Ciampa > > I know a joke about UDP, but you might not get it. > > ------------------------ > > GNU/Linux User #78271 > FSFE fellow #364 > > ------------------------ > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp