Updated patch, which also should fix rotations for rectangles. This should be a complete fix for the reported bug.
On Sat, Mar 31, 2018 at 11:07 PM Russell Oliver <roliver8...@gmail.com> wrote: > No I won't have time to. > > There is still the issue of Eagle rectangles with a rotation applied not > being imported correctly too. > > > On Sat, 31 Mar 2018 14:03 Seth Hillbrand, <seth.hillbr...@gmail.com> > wrote: > >> Hi Russell- >> >> Will you have time to update this patch? If not, I'm happy to revise it >> to handle the cases this weekend. We're getting close to rc2 and I'd like >> to get your fix in before it is released. >> >> Best- >> Seth >> >> 2018-03-27 13:12 GMT-07:00 Seth Hillbrand <seth.hillbr...@gmail.com>: >> >>> Hi Russell- >>> >>> I was unclear. The change in the LSET makes sense. But it looks like >>> you are not setting the solderpaste margin when the solderpaste layer is >>> enabled. I think you need to handle both the case where the paste is >>> enabled and where it is disabled. >>> >>> -S >>> >>> 2018-03-27 12:53 GMT-07:00 Russell Oliver <roliver8...@gmail.com>: >>> >>>> The cream setting is the eagle equivalent to enabling/disabling the >>>> soldering paste layer for the pad. Hence the change in the layer set. >>>> >>>> On Wed, 28 Mar 2018 03:14 Seth Hillbrand, <seth.hillbr...@gmail.com> >>>> wrote: >>>> >>>>> Hi Russell- >>>>> >>>>> Thanks for the patch. However, currently, if there is no e.cream >>>>> setting, the local solderpaste margin gets set. In your patch, if the >>>>> setting is missing, that doesn't happen. >>>>> >>>>> Is this your intention? >>>>> >>>>> -S >>>>> >>>>> 2018-03-27 5:06 GMT-07:00 Russell Oliver <roliver8...@gmail.com>: >>>>> >>>>>> This fixes the issue where the cream setting is ignored when setting >>>>>> the layer set for the pad, but the bug report also mentions that the >>>>>> rotation for rectangles are ignored during import. They rectangle is >>>>>> niavely converted to a polygon. >>>>>> >>>>>> _______________________________________________ >>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>> Post to : kicad-developers@lists.launchpad.net >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>> More help : https://help.launchpad.net/ListHelp >>>>>> >>>>>> >>>>> >>> >>
0001-Eagle-Import-Correct-layer-set-based-on-cream-settin.patch
Description: Binary data
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
