I looked at the commit and I’m starting to remember why I didn’t: there’s also a bug in wxWidgets where if you start typing into a grid cell it will open the editor, but the first keystroke never goes through the validator. So I fixed that too, but between that one and the issue commented in the code you already saw (where the Mac version looks at the original character rather than the one in the event) left me feeling a little uneasy about 5.0.
> On 9 Apr 2018, at 17:12, jp charras <jp.char...@wanadoo.fr> wrote: > > Le 09/04/2018 à 18:03, Jeff Young a écrit : >> FWIW, this is already fixed in 6.0. See the last routine in this file: >> >> https://git.launchpad.net/~jeyjey/kicad/tree/common/validators.cpp?h=6.0 >> > > Perhaps you could commit this fix to the current V5. > It does not look like risky. > > > -- > Jean-Pierre CHARRAS > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : email@example.com > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : firstname.lastname@example.org Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp