Hi Wayne, I see, but I wonder if there is any benefit in making the colon exception just for rescue/cache libraries? I suppose it makes them special in the sense they cannot be used as regular libraries due to illegal character in symbol names.
As I said, I am not familiar with caching/rescue code, but I imagine that once eeschema finds "LibraryName:SymbolName" missing, it could search for "LibraryName_SymbolName" in rescue/cache libraries. I do not insist on a change, just taking an opportunity to learn about caching mechanism. Cheers, Orson On 04/16/2018 03:08 PM, Wayne Stambaugh wrote: > Hey Orson, > > The colons are required to prevent symbol name clashes in the cache > library. I had to prefix the library nickname to the symbol name to > prevent symbols from being overwritten when they exist in more than on > library. In other words, cache library symbol names look just like > LIB_IDs using the LIB_NICKNAME:SYMBOL_NAME format. > > Cheers, > > Wayne > > On 4/16/2018 9:03 AM, Maciej Sumiński wrote: >> Hi Jean-Pierre, >> >> I understand the patch and thank you for the fix, but apparently I do >> not have enough knowledge about caching in eeschema to comment on the >> approach. Frankly, I was a bit surprised to find out that colons are >> permitted in symbol names stored in a cache library. >> >> Regards, >> Orson >> >> On 04/16/2018 11:06 AM, jp charras wrote: >>> Hi Wayne and Orson, >>> >>> Could you have a look into the fix I committed in rev 2974a2c10. >>> Before this fix, the library cache was broken (all symbol names incorrectly >>> saved). >>> This is specific to the cache, but really annoying... >>> >>> Please, see comments in commit 2974a2c10. >>> >>> But I am not sure this is the best way to fix this issue. >>> >>> Thanks. >>> >> >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : email@example.com >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : firstname.lastname@example.org > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : email@example.com Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp