I tested my latest patch and I haven't heard any issues so I went ahead and pushed it. I did not test it with wx 3.1.1 to see if XDG_CONFIG_HOME still worked properly.
Cheers, Wayne On 4/24/2018 8:54 AM, Carsten Schoenert wrote: > Hi, > > Am 24.04.2018 um 12:54 schrieb Strontium: >> Hi Wayne, >> >> I have no personal problem with your patch, but from a standards point >> of view I want to raise this. >> >> As per: >> https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html >> |"$XDG_CONFIG_HOME| defines the base directory relative to which user >> specific configuration files should be stored. If |$XDG_CONFIG_HOME| is >> either not set or empty, a default equal to |$HOME|/.config should be used." >> >> The way I read your patch is that, XDG_CONFIG_HOME is being used to >> specify the absolute path of the kicad configuration directory, not it's >> relative base directory. >> >> My concern is that if XDG_CONFIG_HOME is set to someones "relative base >> config directory", then that relative base config directory is going to >> get filled with kicad config files. > > I second this. > >> Maybe its better to just define a new Kicad specific environment >> variable for the purpose, "KICAD_CONFIG_HOME" for example. Then there >> is no conflict with any existing uses or standards, your patch as >> written, would also then remove the redundant of processing XDG_CONFIG_HOME. > Also true, I already tried to say the same on 8 Apr 2018. > > https://lists.launchpad.net/kicad-developers/msg35345.html > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
