I found some time to test this over the weekend and I could not find any issues. Go ahead an merge this patch so it can be tested more thoroughly before the stable release. I think users are pushing KiCad harder than ever so large board speed is going to continue to be an issue. Thank you everyone for the testing and feedback.
Cheers, Wayne On 6/3/2018 4:44 PM, Maciej Suminski wrote: > FWIW: I have routed a simple board (166 track segments) with the patch > applied, no issues found. > > Cheers, > Orson > > On 06/01/2018 11:17 PM, Wayne Stambaugh wrote: >> On 6/1/2018 3:58 PM, Tomasz Wlostowski wrote: >>> On 01/06/18 20:23, Seth Hillbrand wrote: >>>> I think maybe we are seeing the severity of these bugs differently. >>>> There are three substantial issues addressed by this patch. While they >>>> don't affect many users, they do prevent KiCad from being used for >>>> larger, more complex boards that we nominally support. This is a also >>>> regression from v4. >>> >>> Hi all, >>> >>> I vote for merging Seth's patch. >>> >>> For those concerned about its correctness: the connectivity algo is >>> designed in such way that in case of bugs in collision search (other >>> than in BOARD_ITEM::HitTest()/POLY_GRID_PARTITION which haven't been >>> touched for a year), it may find false unconnected items, but not false >>> connected ones. In the worst case, we'll have false 'unconnected items' >>> warnings in the DRC, but I doubt there will be any. The patch is simple >>> and elegant. >>> >>> Tom >> >> Tom, >> >> Have you actually tested the patch? Voting for it doesn't help me make >> an informed decision. What I really need is test feedback. I'm not >> opposed to merging it but I would like as large of a test group as >> possible so I have some confidence that it's not going to cause a bunch >> of issues this close to the stable release. I plan on testing it >> tomorrow but I am an infinite sample of one. A few other testers would >> be appreciated before I'm willing to sign off on committing it. >> >> Cheers, >> >> Wayne >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
