Well done, Adam! > On 23 Jul 2018, at 04:47, Adam Wolf <adamw...@feelslikeburning.com> wrote: > > Thanks, Wayne! > > After two long days, I was able to solve the Python issue. I looked > for a root cause, and stopped when I got into a CMake module that is > causing other problems and I was already planning to fix after the V5 > release. > > I added an executable test that checks to see if the same sort of > issue is happening to the build, and a fix. > > Happy Version 5 day, everyone! I'm going to be slow to answer KiCad > emails for a few days, unless there is some sort of emergency. > > Adam > > On Sat, Jul 21, 2018 at 10:44 AM Wayne Stambaugh <stambau...@gmail.com> wrote: >>> Adam, >> >> Don't sweat it. These things always seem to happen at release time. >> Better to fix it now than to find out after it's already released. Keep >> me posted. >> >> Thanks, >> >> Wayne >> >> On 07/21/2018 10:09 AM, Adam Wolf wrote: >>> I must add that I have had literal nightmares about holding up the V5 >>> release. This is a little bit like actually going to school naked or >>> having all of your teeth fall out. >>> >>> On Sat, Jul 21, 2018, 8:52 AM Adam Wolf <adamw...@feelslikeburning.com >>> <mailto:adamw...@feelslikeburning.com>> wrote: >>> >>> The tests that are not passing are some Python ones. They have to do >>> with how Python is embedded in the package. >>> >>> This one passes: >>> Open up KiCad.app, and open up the Python scripting console. Type >>> import pcbnew and press enter. It shouldn't show an error. Verify that >>> the build date of Pytohn is the same as the build date of the package. >>> >>> But these three do not. >>> >>> ====== >>> >>> Open up pcbnew.app, and open up the Python scripting console. Type >>> import pcbnew and press enter. It shouldn't show an error. Verify that >>> the build date of Python is the same as the build date of the package. >>> >>> Open up the terminal, and run >>> >>> kicad.app/Contents/Frameworks/Python.framework/Versions/Current/bin/python. >>> It shouldn't show an error. Verify that the build date of Python is >>> the same as the build date of the package. >>> >>> Open up the terminal, and run cd >>> kicad.app/Contents/Frameworks/python/site-packages/; >>> ../../Python.framework/Versions/Current/bin/python -m pcbnew. It >>> shouldn't show an error. >>> >>> ====== >>> >>> These tests have worked for months! Embedding python in a more >>> correct way is the whole basis of why I redid the packaging for V5 >>> *sigh* :) I checked them when I built 5.0.0-rc3, and I double checked >>> them now. 5.0.0-rc3 worked fine. >>> >>> I am currently suspecting changes in the build scripts since July >>> 5th--even though they all look innocuous. I am now doing some >>> differential builds to see what's causing the problem. >>> >>> Adam >>> >>> >>> >>> On Sat, Jul 21, 2018 at 5:07 AM Maciej Suminski >>> <maciej.sumin...@cern.ch <mailto:maciej.sumin...@cern.ch>> wrote: >>>> >>>> Hi Adam, >>>> >>>> What is the regression? Perhaps we can help debugging. >>>> >>>> Cheers, >>>> Orson >>>> >>>> On 07/21/2018 08:23 AM, Adam Wolf wrote: >>>>> Hi folks! >>>>> >>>>> While trying to create the 5.0.0 package for macos tonight, I >>> ran into >>>>> a test regression that I do not see on RC3. I am debugging, but >>> it is >>>>> very late in my local timezone and I must sleep. >>>>> >>>>> I have an obligation in the morning tomorrow but I will continue >>>>> debugging this. I do not expect this to take more than a day. >>>>> >>>>> (Kinda glad I have a test doc, now... would have been a real shame >>>>> had I released a version with a Python issue after all my hard work >>>>> getting it working!) >>>>> >>>>> Adam >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/%7Ekicad-developers> >>>>> Post to : kicad-developers@lists.launchpad.net >>> <mailto:kicad-developers@lists.launchpad.net> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/%7Ekicad-developers> >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/%7Ekicad-developers> >>>> Post to : kicad-developers@lists.launchpad.net >>> <mailto:kicad-developers@lists.launchpad.net> >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/%7Ekicad-developers> >>>> More help : https://help.launchpad.net/ListHelp >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
