Hi John, Sorry to send you on a goose chase; I should have mentioned in the commit notes that the checkbox moves to the Render tab to be consistent with PcbNew:
You can also change the colour there…. Cheers, Jeff. > On 26 Jul 2018, at 18:51, John Gehrig <jdg.geh...@gmail.com> wrote: > > Reference images didn't upload... Trying again. > > On Thu, Jul 26, 2018 at 1:45 PM, John Gehrig <jdg.geh...@gmail.com > <mailto:jdg.geh...@gmail.com>> wrote: > Hi everyone, > > I noticed recently that worksheets are now displayed in the Gerbview GAL > rendering engine. It appears this behavior was added to GAL in the following > commit: > > https://github.com/KiCad/kicad-source-mirror/commit/9a228d8ec9eff6fcfc0651a3f98414f95ba8fe69#diff-65128126b95a4ffc3801d22ac0150f48 > > <https://github.com/KiCad/kicad-source-mirror/commit/9a228d8ec9eff6fcfc0651a3f98414f95ba8fe69#diff-65128126b95a4ffc3801d22ac0150f48> > > The above commit changes behavior from the legacy rendering engine, where the > default option "Full size without limits" hides the worksheet from display. > Recently this dialog option was deleted in the commit below (this makes sense > it didn't do anything at the time; it was broken): > > https://github.com/KiCad/kicad-source-mirror/commit/7841f8a466d47a8db44d1701ea7366d6e0560ff3 > > <https://github.com/KiCad/kicad-source-mirror/commit/7841f8a466d47a8db44d1701ea7366d6e0560ff3> > > > I put together a change that restores the old behavior (GAL and Legacy) and > makes the settings more clear in the dialog. Two check boxes are created > because m_showBorderAndTitleBlock, and m_showPageLimits are technically two > separate settings in EDA_DRAW_FRAME. Since a border cannot be displayed > without the worksheet, the first checkbox disables the other. > > > > > If this looks worthwhile, let me know what branch to patch against (5.1 vs > Master). I can address any comments and generate a proper patch file with > commit message. > > Cheers, > John > > <gerbview.png><dialog.png>_______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp>
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
