Hi Zoltan- Thank you for your contribution. As a quick note on our status right now, we are focusing on the 5.1 branch that is moving eeschema to our underlying GAL framework along with dialog revisions. After that is released, we'll begin accepting new features such as your patch.
The patch looks like a nice feature. To be accepted, we'll need it to follow KiCad coding policy ( https://kicad-source-mirror.readthedocs.io/en/stable/Documentation/development/coding-style-policy/) consistently. There are a few places where you are missing spacing around commas or parentheses. Also, please ensure that you do not use "magic" numbers, e.g. 10000000. Instead use constexpr with well-named variable and comment for units. I would suggest making these revisions and attaching the patch to the associated bug report. This will ensure that we don't lose track between now and when v6 development opens. Best- Seth Am So., 9. Sep. 2018 um 11:11 Uhr schrieb Zoltan Gyarmati < [email protected]>: > > To help manaul drilling, the print dialog provides option to > print small drill marks. > This patch adds one more option to set custom drill mark size, > while keeping backward compability with previously saved > configuration values. > > Fixes: lp:1287362 > https://bugs.launchpad.net/kicad/+bug/1287362 > > Signed-off-by: Zoltan Gyarmati <[email protected]> > --- > pcbnew/dialogs/dialog_print_using_printer.cpp | 22 +- > .../dialog_print_using_printer_base.cpp | 36 +- > .../dialog_print_using_printer_base.fbp | 541 ++++++++++++++++-- > .../dialogs/dialog_print_using_printer_base.h | 13 +- > pcbnew/pcbplot.h | 1 + > pcbnew/print_board_functions.cpp | 21 +- > pcbnew/printout_controler.h | 4 +- > 7 files changed, 584 insertions(+), 54 deletions(-) > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
