Should I file a bug or just send in a patch in a bit? Hey, do we think there might be a similar issue on Windows?
Adam On Tue, Dec 18, 2018, 11:21 AM Jeff Young <[email protected] wrote: > Hi Adam, > > I’d stick it in a function in common.cpp. > > Cheers, > Jeff. > > > On 18 Dec 2018, at 14:07, Adam Wolf <[email protected]> wrote: > > Hi folks! > > I've been tracking a macOS issue that I thought was a packaging issue, but > I think needs to be fixed in KiCad. > https://github.com/KiCad/kicad-mac-builder/issues/227 > > Basically, the BOM Generator dialog is running python but it's running the > system python (with the bundled python's libraries :D). We want it to run > the bundled python. When users modify the command to use the bundled > python, it works fine. > > So I dug into it, and we fix the PATH so that when something from pcbnew > runs "python", it runs the right python on both macOS and Windows. > > > https://github.com/KiCad/kicad-source-mirror/blob/27d57d9191d0807722f2cd2b6b61cdb67e247612/pcbnew/pcbnew.cpp#L260 > > So, code organization-wise, what's the best way to run something similar > in eeschema? Do we do it in a more global area? Do we pull it into a > function and call it in both places? > > I'm handy with C++ and Kicad building, but I have zero intuition for how > things are arranged in the code base--I just haven't spent that much time > on it. Any tips or thoughts would be greatly appreciated. > > Thanks folks! > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
