On 1/15/19 9:21 AM, Wayne Stambaugh wrote:
> Hi Steve,
>
> On 1/15/2019 8:51 AM, Steven A. Falco wrote:
>> I'll look at that. The worst burst of backspaces is about 7 characters
>> long, so I could accumulate 14 chars or so before making a decision. In
>> other words, run a circular buffer, and when I see the first non-backspace
>> after a string of backspaces, then process the buffer.
>>
>> But I'm starting to think that the better approach is to drop this patch
>> from the official tree, and just put my original patch into Fedora-only, as
>> a temporary patch, to be removed when the library issue is corrected.
>
> This may be the way to go as this is only temporary until the ng-spice
> library is fixed. I'm assuming this issue is specific to Fedora. If
> not, we can re-evaluate it at the time that it is broken on another
> platform.
I committed my original patch into the Fedora build system. A new build will
appear in rawhide in a day or two, and it will appear in Fedora 29 after a week
or two, once the karma process runs its course. Thus Fedora users can start
enjoying ngspice soon. I'll keep track of the ngspice library, and if a fix
appears there, then I'll remove my patch.
I did take a stab at a new, efficient patch which addresses Seth's concern -
but after studying the dynamics of the message passing, I don't think it really
matters. Messages always seem to break on carriage-return boundaries, so
either patch will work without any loss of data.
I attached the new patch here so it won't get lost. It behaves about the same
as the earlier one, but it does print some extra '%' characters that are left
over after the backspaces are processed. Thus, I actually prefer the original
patch, because it produces slightly cleaner output.
Nick - Do you want to put either version into the Copr builds?
Steve
P.S. - This time, I tried to follow the coding style, as per Wayne's email. :-)
From d8888c9ccf62a0f38ef9b1f3a8be50bb1ac87dcf Mon Sep 17 00:00:00 2001
From: "Steven A. Falco" <[email protected]>
Date: Tue, 15 Jan 2019 14:00:20 -0500
Subject: [PATCH] Filter out backspaces from ngspice status lines.
The ngspice library can output "percent complete" status lines, and the
amount of status produced can exceed 1 megabyte. Those lines contain
embedded backspaces, and don't print correctly. Therefore, we filter
them to remove the backspaces and preceding characters.
---
eeschema/sim/sim_plot_frame.cpp | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/eeschema/sim/sim_plot_frame.cpp b/eeschema/sim/sim_plot_frame.cpp
index 3812d0c3b..74d0d1d6e 100644
--- a/eeschema/sim/sim_plot_frame.cpp
+++ b/eeschema/sim/sim_plot_frame.cpp
@@ -1282,7 +1282,25 @@ void SIM_PLOT_FRAME::onSimUpdate( wxCommandEvent& aEvent )
void SIM_PLOT_FRAME::onSimReport( wxCommandEvent& aEvent )
{
- m_simConsole->AppendText( aEvent.GetString() + "\n" );
+ wxString t = aEvent.GetString();
+ wxString buffer = "";
+
+ for( wxString::iterator it = t.begin(); it != t.end(); ++it )
+ {
+ if( *it != '\b' )
+ {
+ // Not a backspace; store it in the buffer.
+ buffer += *it;
+ }
+ else
+ {
+ // Backspace; toss the last character in the buffer (if any), and
+ // toss the backspace.
+ buffer.RemoveLast();
+ }
+ }
+
+ m_simConsole->AppendText( buffer + "\n" );
m_simConsole->SetInsertionPointEnd();
}
--
2.20.1
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
