I’ve never trusted any of the auto-formatters, but that might just be me.
> On 20 Mar 2019, at 16:46, Brian <[email protected]> wrote: > > I'm trying to get better at not breaking the KiCad style guidelines, but then > I see the clang-format tool make suggestions like this: > > - static LIB_TEXT* loadText( std::unique_ptr< LIB_PART >& aPart, > LINE_READER& aReader, > - int aMajorVersion, int aMinorVersion ); > - static LIB_RECTANGLE* loadRectangle( std::unique_ptr< LIB_PART >& aPart, > - LINE_READER& aReader ); > + static LIB_TEXT* loadText( std::unique_ptr<LIB_PART>& aPart, > LINE_READER& aReader, > + int aMajorVersion, int aMinorVersion ); > + static LIB_RECTANGLE* loadRectangle( std::unique_ptr<LIB_PART>& aPart, > LINE_READER& aReader ); > > This doesn't seem right to me, in particular pulling the second line of the > loadText definition leftward and removing the spaces around template > parameters. It makes me reluctant to blindly do a `git clang-format` before > a commit. > > Comments / advice? > > Thanks, > -Brian > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
