Hi Steve, Your patch no longer applies cleanly as there has been some serious refactoring and legacy code removal. I think your patch is a good idea but it will need to be fixed. I do have a few comments from your original patch:
* Please use `git commit` to commit your code to your local repo and `git format-patch` to create patches to send to the mailing list. * There tabs and indentation errors in your original patch. * I don't think you need to make the precision of millimeter grid units 4. 2 should be more than acceptable given that you are using 3 for inches units. You may want to increase this by one for the board editor. The board editor has far greater precision than the schematic editor. Thanks, Wayne On 5/24/19 9:55 AM, Steven A. Falco wrote: > On 5/23/19 1:59 PM, Wayne Stambaugh wrote: >> Hey Steve, >> >> Adding "grid" to the coordinates in the status bar is not correct. >> These are the cursor coordinates not the grid coordinates. To add the >> current grid size to the status bar, you would need to add another pane >> to status bar and fetch the current grid setting from the current SCREEN >> object. > > In the attached patch I tried to make the changes you suggested, Wayne. > Please let me know if it is ok, or if there are still problems. > > I find the panes confusing, because mainframe.cpp allocates 3 panes via > "CreateStatusBar( 3 );", but I see higher numbers elsewhere in the code, such > as EDA_DRAW_FRAME::DisplayToolMsg which uses "SetStatusText( msg, 5 );". I > increased the count in mainframe.cpp to 4 to cover the my new grid pane, but > I don't know if I really needed to do that. > > Steve > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
