Andrew, I'm not sure why you need a half step rotation when you can just change the rotation angle to 45°. I'm not opposed to this change but given that we are running out of hotkeys, I don't know if this is the best use of them.
Cheers, Wayne On 6/9/2019 8:40 PM, Andrew Lutsenko wrote: > I could replace diff pair dimensions shortcut with something else if > that is fine by devs, Ctrl+Shift+I is available. > > On Sat, Jun 8, 2019 at 3:49 AM Ian McInerney <[email protected] > <mailto:[email protected]>> wrote: > > Just a note, the hotkey ctrl+shift+R is already assigned to > "Differential Pair Dimensions" by default so this would introduce a > duplicate hotkey conflict. It probably makes sense for this action > to be ctrl+shift+R, but that means that the other needs to be changed. > > Also, as a side note to the lead devs, is it still necessary to have > the hotkeys say (Modern Toolset only) in the master branch? > > -Ian > > On Sat, Jun 8, 2019 at 8:22 AM Andrew Lutsenko <[email protected] > <mailto:[email protected]>> wrote: > > Hi all, > > I frequently find that I need to rotate a footprint or a few by > 45 degrees. To do that I either have to edit it's properties > (works if it's just one but slow) or change pcbnew preferences > (very slow). > I thought I'd add a quick shortcut to rotate selected items by > half of the configured rotation angle and learn a bit of tool > related code in the process. Please see attached patch for that. > > I suspect the way I handled passing double parameter to the > action is not ideal but it's impossible to have a pointer to > constant literal without storing it in a variable (to my > knowledge). I'm open to suggestions on how to clean up that > part, maybe move the constants somewhere? > > Regards, > Andrew > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > <mailto:[email protected]> > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
