Hi Ian, I merged your patch. Thanks for your contribution!
Cheers, Jeff. > On 14 Aug 2019, at 00:40, Ian McInerney <ian.s.mciner...@ieee.org> wrote: > > Right now the addition of the Close item for the non-main windows is > scattered in the menu creation functions. This means it is easy to leave out > the accelerator key entry when adding a new one (yes, I forgot that in > cvpcb...). This patch will push the creation of the menu item into a common > method in CONDITIONAL_MENU that is then just called by each window. It also > introduces a tooltip for the item that includes the app name. This unifies > all the close items, and ensures they have the proper CTRL-W accelerator key > assigned. > > Note that this does not unify the one for the simulation window. That window > is a wxFormbuilder window so its menu is not a CONDITIONAL_MENU and can't use > this. > > -Ian > <0001-Unify-menu-item-creation-for-closing-a-window.patch>_______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
