This somehow got lost in my email, but I have now found a case where this is needed in the "wild" (the master branch). For bug https://bugs.launchpad.net/kicad/+bug/1834547, it appears that on Linux the hotkey architecture is trying to run the action for place symbol pin instead of the place power action. These two actions are never active on the same editing session, so it is a valid configuration. Applying this patch fixes the behavior, and the place power symbol action is actually called.
-Ian On Mon, Aug 12, 2019 at 9:02 PM Wayne Stambaugh <[email protected]> wrote: > What is the status of this patch? > > Cheers, > > Wayne > > On 8/8/19 7:16 PM, Ian McInerney wrote: > > In the current framework, if more than one global actions share the same > > hotkey (even if they are not all active in the current tool manager), > > the dispatcher will only choose the final action (in what seems to be > > alphabetical order) to run. I think that the correct behavior should > > instead be to loop through all global actions that have the hotkey until > > one handles it. > > > > The attached patch implements this change. > > > > -Ian > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : [email protected] > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
