Thanks! I agree a user setting would be best, preferrably with some nice included palettes.
I left the old commented palettes since there was already several other palettes there. Perhaps it would make sense to just backport the bug fix, but keep the old 8-color palette? /Jonatan > 11 nov. 2019 kl. 18:35 skrev Ian McInerney <[email protected]>: > > > Jonatan, > > Thank you for putting this together. Overall I think it looks good, but the > only issue I saw was that the SIM_PLOT_FRAME::generateColor() function seems > to be becoming a graveyard for old colors with 4 old attempts at creating > color profiles now commented out. I have merged it into master as is (we can > leave those old attempts in there for now to show what has been done before), > but I think it would be good to have a larger discussion about making these > plot colors user-configurable. > > A good path forward would be to create a new settings page that allows the > user to add/define/modify the simulation colors that are used for drawing the > lines. That way they can also add more colors to the 16 if they prefer. > Whether this ends up being stored with the simulation settings or in the main > Eeschema color settings that will be introduced in v6 is something we should > discuss. > > I am on the fence about whether this should be backported to the 5.1 branch > when 5.1.6 development opens. On the one hand this fixes a bug, but the > change in color scheme in a minor release could annoy some users (since there > is no way of changing the colors). > > -Ian > >> On Mon, Nov 11, 2019 at 3:19 PM Jonatan Liljedahl <[email protected]> wrote: >> And here's a screenshot showing how (some of the) new colors looks like. >> >> On Fri, Nov 8, 2019 at 5:13 PM Jonatan Liljedahl <[email protected]> wrote: >> > >> > NEW: The simulator plot now avoids colors already in use, if possible. >> > The palette is replaced with a larger one with less saturated colors. >> > >> > Fixes: lp:1851372 >> > * https://bugs.launchpad.net/kicad/+bug/1851372 >> > >> > >> > -- >> > /Jonatan >> > http://kymatica.com >> >> >> >> -- >> /Jonatan >> http://kymatica.com >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
