On Tue, Jul 13, 2010 at 10:45:10AM -0700, Daniel Dunbar wrote: > Hi Peter, > > Patch looks excellent, please commit! Applied in r108347.
> One question, what does this do: > + vc_setInterfaceFlags(vc, EXPRDELETE, 0); > ? > > It reads like it disable expression freeing, which sounds scary for > memory use. Can you add a comment if it is something subtle? It certainly doesn't disable expression freeing altogether! It disables a newer memory management mechanism in STP which interferes with our use of ExprHandle smart pointers. More details are in the comment. > Would it make sense to push the STP guys to make a stable release, > which we could recommend to users? That would be one step in the > direction of killing off our internal STP copy. It may be worth asking them, though I don't know how well that would align with their own goals. The development STP does seem to be more of a testbed for newer ideas at the moment. Thanks, -- Peter
