> On Nov. 19, 2012, 8:34 a.m., Cristian Oneț wrote: > > kmymoney/widgets/transaction.cpp, line 336 > > <http://git.reviewboard.kde.org/r/107373/diff/2/?file=95304#file95304line336> > > > > If you set the ctx.palette to option palette the selected test is not > > needed anymore. > > Alessandro Russo wrote: > ctx.palette = option.palette; is already present at row 333, if I remove > this test the text in the selected row is black and not white...
You're right, I was thinking that the palette is already prepared considering m_selected but that's not the case; even the old code had the 'if' to select the highlight color. - Cristian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107373/#review22206 ----------------------------------------------------------- On Nov. 20, 2012, 12:13 a.m., Alessandro Russo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107373/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2012, 12:13 a.m.) > > > Review request for KMymoney. > > > Description > ------- > > Fixed: > - when closing the split dialog focus go to tag field and not to memo field > - if the user write in the tag line edit the name of a closed tag or of a > tag already included in the transaction an information modal dialog will > appear and the line edit will be cleared. > - restore right color for text in the ledger > > > Diffs > ----- > > kmymoney/dialogs/transactioneditor.cpp 1a5e773 > kmymoney/widgets/kmymoneymvccombo.h ad6ae92 > kmymoney/widgets/kmymoneymvccombo.cpp 1053a1a > kmymoney/widgets/transaction.cpp 7525851 > > Diff: http://git.reviewboard.kde.org/r/107373/diff/ > > > Testing > ------- > > Compile and run as intended. > > > Thanks, > > Alessandro Russo > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
