-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114352/
-----------------------------------------------------------
Review request for KMymoney and Cristian Oneț.
Bugs: 312816
http://bugs.kde.org/show_bug.cgi?id=312816
Repository: kmymoney
Description
-------
This patch extends the code of REVIEW: 112989, and as I cannot add a patch to
Cristian's review request, I have raised a new request.
a) When an account is loaded, the columns for the kMyMoneyEdit fields have
extra white-space, to allow for the calculator and date buttons, but these
buttons won't appear until editing starts. This happens because
m_usedWithEditor was being enabled in KGlobalLedgerView ctor. I've changed this
so m_usedWithEditor is enabled instead in KGlobalLedgerView::startEdit() and
reset in KGlobalLedgerView::slotLeaveEditMode().
b) When a transaction is opened for editing, the above columns are widened for
the buttons. However, this window widening is not helped by potentially
surplus white-space appearing in the Description column. This can frequently
happen if the memo text is wide and possibly originally multi-line. When not
editing, the multi-lines are combined into a wider field, but the multi-lines
are restored when editing but the Details column does not notice this, so
retains its full width. I've remedied this by reducing the width to that of
the widest sub-string.
Diffs
-----
kmymoney/views/kgloballedgerview.cpp 000393c
kmymoney/widgets/register.cpp 56bf46d
Diff: http://git.reviewboard.kde.org/r/114352/diff/
Testing
-------
Much resizing of many checking and investment accounts, both while in edit mode
and not.
Thanks,
Allan Anderson
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
