----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129796/#review102006 -----------------------------------------------------------
Otherwise, it looks good to me. Anyone else, I am not an SQL expert. kmymoney/mymoney/storage/mymoneydbdef.cpp (line 510) <https://git.reviewboard.kde.org/r/129796/#comment68219> Please remove traling blanks - Thomas Baumgart On Jan. 8, 2017, 8:24 nachm., Marc Hübner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129796/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2017, 8:24 nachm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > query parameters are being matched only based on their name. If one parameter > starts with the name of another, this leads to conflicts, e.g. :payeeId and > :payeeIdentifier --> if both matches are replaced by NULL, this results in > the second match being replaced to NULLentifier, which is obviously not > intended. > > > Diffs > ----- > > kmymoney/mymoney/storage/mymoneydbdef.cpp f85cc47 > > Diff: https://git.reviewboard.kde.org/r/129796/diff/ > > > Testing > ------- > > manually executed the rendered SQL statements in Mysql to create the database > tables. > > > Thanks, > > Marc Hübner > >
