http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681
--- Comment #13 from Katrin Fischer <[email protected]> --- Comment on attachment 30795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30795 This patch update the code and fix MARC flavour problem by removing all subfields $9 from the imported record. Review of attachment 30795: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6681&attachment=30795) ----------------------------------------------------------------- Starting with a code review here: 1) This patch lacks a test plan and a description of the changes - please add those to the commit message. 2) This patch also doesn't do, what the bug description says. It not only removes $9 subfields, but it also removes items. I am not quite happy with both those features combined into one method. I'd like it a bit better if they were separated - but there might be reason to have both combined? 3) Anyway, we need a unit test for the new routine(s). 4) It's not MARC-agnostic, but only adds code for MARC21 - not for UNIMARC or NORMARC. It would be nice to add code for the other dialects as well or at least file bugs for them. ::: C4/Biblio.pm @@ +2800,5 @@ > + } > + > + # Remove all authid links ($9) in the record > + if ( $marcflavour eq "MARC21" ) { > + my @heading = qw(100 110 111 130 440 600 610 611 630 648 650 651 655 > 700 710 711 730 800 810 811 830); I am a bit torn about hardcoding the fields. One idea I had was to look up the authority linked fields in the frameworks - but you might have a library that doesn't use authorities at all or differently and import from another that does use them - in that case it won't work. So I don't have a better idea currently. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
