http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598
--- Comment #13 from Kyle M Hall <[email protected]> --- (In reply to Jonathan Druart from comment #12) > Kyle, > I am sorry but this patch c/p almost all the code from > tools/import_borrowers.pl. > I am not sure this is the right way to do. That is why my initial patch allowed the existing tools/import_borrowers.pl script to be used from the command line. However, I was told that is no longer allowed ( tools/export.pl has this behavior ), though it is not stated in the coding guidelines. > The script should also use Pod2Usage (instead of the print_help routine). Is this in the coding guidelines? > I am completely aware of the quantity of work to provide to reach a correct > quality of core here: refactoring, unit tests, etc. Not sure why this would be required for code we already know works... While I agree in general, this is proven code, and your proposal would add an order of magnitude to the development with no real gains. I would much prefer we allow tools/import_borrowers.pl to be used from the command line for this exact reason. > But I am pretty sure this script should not be pushed as it. I would respectfully disagree ; ) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
