http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12815

Indranil Das Gupta <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected],
                   |                            |[email protected]

--- Comment #7 from Indranil Das Gupta <[email protected]> ---
(In reply to Owen Leonard from comment #4)
> This appears to be working correctly for me, but I have a couple of comments:
> 
> 1. There should not be comments added to the markup referencing the bug
> number. We have git for tracking changes.

Will remove and update. 

> 2. Instead of adding two new include files, why not add that template logic
> to doc-head-close.inc? I think the creation of new include files is only
> useful if they will be included by multiple templates.

For, the staff client, I think I'll have to introduce [% USE Koha %] into
doc-head-open.inc

> The functionality of the plugin itself seems to be good, but I think it
> should be tested again by someone whose native language is represented in
> the list of options.

that makes sense. 

@Amit: Can you please test it out?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to