http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577
--- Comment #84 from Martin Renvoize <[email protected]> --- Comment on attachment 31084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31084 Bug 11577: Unit tests Review of attachment 31084: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11577&attachment=31084) ----------------------------------------------------------------- Should we be testing against auto_renew => 1 for any cases in Circulation_Issueingrule.t per chance.. probably not so I'm OK with this once a last typo fix is done. Thanks for adding tests to cover your feature in Circulation.t. I'm happy that these work well now. ::: t/db_dependent/Circulation_Issuingrule.t @@ +246,4 @@ > $sampleissuingrule2->{renewalsallowed}, > $sampleissuingrule2->{renewalperiod}, > $sampleissuingrule2->{norenewalbefore}, > + $sampleissuingrule1->{auto_renew}, Is this a copy/paste error here, should it be $sampleissuingrule2->{auto_renew} [spot to '2' instead of '1'] ? @@ +272,4 @@ > $sampleissuingrule3->{renewalsallowed}, > $sampleissuingrule3->{renewalperiod}, > $sampleissuingrule3->{norenewalbefore}, > + $sampleissuingrule1->{auto_renew}, As above.. is there a copy paste issue here? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
