http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877
M. de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #26 from M. de Rooy <m.de.r...@rijksmuseum.nl> ---
QA Comment:
Looks quite good to me. Some small details still need attention (see also
earlier remark of Jonathan):
my $infos = get_infos_syspref($marcrecord, ['itype']);
This does not seem to make sense. According to the description of the pref
itype is not contained in the pref. (So you create/use an undocumented feature
here?) Note that if I just comment those lines, the items will fall back to the
item type that I had in 942c of the biblio record somehow? Any idea where that
comes from?
On the other hand, we could add this to the syspref description and keep it.
Although I do not mind to set the home and holding branch of the item as you do
now in the same code region, it is not really necessary. They could be null as
well. If I comment the lines, the items will be created too. (Note that I do
not specifically understand the concerns of Jonathan for this field.)
Your argument on the notforloan to -1 makes sense to me. I would suggest to
keep that one at least.
Changing status to reflect need for small adjustments.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
