http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342
--- Comment #76 from Jonathan Druart <[email protected]> --- (In reply to Katrin Fischer from comment #74) > 1) (trivial) The QA script complained about a char character and about a > missing > blank line before a =cut in Serials.pm - I am attaching a small patch > to fix those. If you think they are good, feel free to squash them > into the follow up. I don't reproduce :-/ I will be happy if you can provide a followup for that :) > 2) (normal) Your patch removes the ISSN column on the claims.tt page. I have > confirmed the ISSN is displayed before your patch - so I think we should > keep it. Oops, fixed! > 3) (question/normal) Without the patch, a vendor won't show up in the list > of vendors on the claims page, if the number of late issues is 0. Now > the vendor is shown in the list with a (0) behind the name. I wonder > if it would be more ergonomic to not list them or if libraries want to > have those listed as well. I don't have supplier with (0). Maybe it's suppliers with serials already claimed? > 4) (note) When you select no issue in the list, a message is shown: > Please select at least one item. > I think for translation it would be a bit nicer to make it more > explicit: > Please select at least one issue. Not introduced by this patch, but fixed :) > 5) (major) The tests are failing on my database :( I don't reproduce neither, but it should be fixed. I remove all issues before to launch tests in the followup. > 6) (normal) My staff user has a primary email defined, but I still get the > message: > No email is configured for your user. > The vendor has an email defined as well and all checkboxes are checked. > I double checked - I am not sure what's going wrong here. You have to logout/login to take into account the email address modification. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
