http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Kyle M Hall <[email protected]> --- I have no objections to moving these behaviors to cleanupdatabase. My only concern would be to make sure upgraders have clear notification that the old cron scripts have gone away and the functionality has been moved. delete_expired_opac_registrations.pl is indeed meant to delete patron accounts that are still set to the default category after a set time. I agree there is some confusion here. There are two use cases: 1) This PatronSelfRegistrationDefaultCategory is a provisional category which is meant to allow a patron to immediately access online resources but not to check out items. In the scenario, the patron is supposed to come into the library within a given amount of time to verify his or her identity, and have a librarian change the patron category to a permanent category. That way the patron is now a full-fledged member who can check out items. This is the scenario where delete_expired_opac_registrations.pl is meant to be used. 2) The PatronSelfRegistrationDefaultCategory *is* full fledged membership category. In this scenario no verification is required by the library and delete_expired_opac_registrations.pl should *not* be used, ever. delete_unverified_opac_registrations.pl is more of a garbage cleanup. If PatronSelfRegistrationVerifyByEmail is enabled, patrons try to create an account, but never confirm the account creation via the emailed link. We don't want these to just pile up, so this script removes them. Note this is only for new patron account submissions, and not for patron modification requests to existing accounts ( hence where borrowernumber = 0 ). > I propose the following changes: > [1] Move these actions to cleanupdatabase. Do they really need two separate > scripts? I think delete_unverified_opac_registrations.pl is a prime candidate for folding into cleanupdatabase. I suppose delete_expired_opac_registrations.pl could be moved into it as well. I would not object to that, but it's not quite the same as removing crufty old data. This script deletes what may be active patron accounts. It isn't really cleanup. I do like the idea of one unified script though. > [2] Rename the Delay preference. Name and description conflict now. We could > make name and description cover both cases: (a) verify is on and still > unverified and (b) verify is off and still in the initial category. I'm questioning whether we should have the preference at all. Is PatronSelfRegistrationExpireTemporaryAccountsDelay something we really need libraries to be able to change without the help of an administrator? Maybe this should be a days parameter like it is for delete_unverified_opac_registrations.pl? > [3] Trigger the borrowers/category delete only if Verify is off and the > renamed delay has been past. This part I'm not understanding. When you say Verify do you mean PatronSelfRegistrationVerifyByEmail, or being verified by having the patron category changed? I don't think we should automate the triggering of these deletions. This behavior may be very custom depending on the needs of the librarians. So in summary, my suggested course of action would be to: 1) Fold both scripts into cleanupdatabase with separate switches and time parameters for each ( maybe --delete-expired-self-registration=<days> and --delete-unverified-self-registrations=<hours> so we don't need two parameters for each. 2) Remove PatronSelfRegistrationExpireTemporaryAccountsDelay completely 3) Update PatronSelfRegistrationDefaultCategory to indicate that if they use --delete-expired-self-registration=<days> that this category should *only* be for provisional self-registered patrons What do you think? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
