http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #157 from Katrin Fischer <[email protected]> --- Hi Kyle, I tried to test this last minute, but I found a blocker: Changing the allowance from the 'personal details' page is not being saved. I tried using the update button and also make a full change request, nothing worked. Firefox shows a network error: NetworkError: 404 Not Found - http://localhost/cgi-bin/koha/svc/patron/show_checkouts_to_relatives If Javscript is needed to make this work, please also consider a non-Javascript fallback. The stars * mark questions or problems, questions are questions :) 1)* Code review - OK passes QA script and tests - OK ModPrivacy is removed, no other references found * Note: There is some use of the TT plugin $EncodeUTF8, which might be obsoleted if the UTF-8 patches get pushes. 2)* Database structure - OK Patch adds an issue_id PK column to issues/old_issues * Problem (normal): I think old_issues PK should not be AUTO_INCREMENT (see old_reserves) - OK Patch adds privacy_guarantor_checkouts to borrowers/deletedborrowers * Problem (trivial): Please add 'AFTER privacy' to updatedatabase to ensure the correct sequence for new and updated installations - OK 2 new system preferences are added: - AllowPatronToSetCheckoutsVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - OK updatedatabase works - OK changes with kohastructure are consistent 3) Testing the new issue_id - OK Numbering after update appears ok: old_issues: 1-23 issues: 24-26 - OK New Check-outs get the next higher number. - OK Check-ins are correctly moved to old_issues. 4) Testing changes on borrower record (staff) - OK Deleted patron is moved to deletedborrowers. - OK Editing patrons. - OK Adding patrons. 5) Testing 'Show checkouts to guarantor' (staff) * Details: The information now always shows on the patron record, if yes or no independent from the system preference settings independent from the patron being guarantor/guarantee Question: Can we think of a better way here? Maybe only show the information when (either pref is ON and the patron is a guarantee) OR (setting is set to yes)? Really not sure what is best here, sounds too complicated. * Edit form: Settings shows next to privacy Question: Maybe it would make sense to group it with the guarantor information? * Terminology: The setting is "...to guarantor" but the tab is labelled "Relative's checkouts" Question: Should we make them match? 6)* Testing options and visibility in OPAC * AllowPatronToSetCheckoutsVisibilityForGuarantor is ON OpacPrivacy is OFF Problem (blocker) changes to the display made from the personal details tab won't save. - OpacPrivacy is ON OK Setting can be changed. - AllowPatronToSetCheckoutsVisibilityForGuarantor is ON OK Setting is not displayed. Found preexisting BUGS! * Problem (also in master): Author's don't display correctly on the relative's checkouts issues list in staff: Vogelfang und Vogelberingung / by _AUTHOR_ Bub, Hans * Problem (also in master) Table layout on the 'details' tab in staff is broken. Notes: - Should we not generally display information about an existing guarantor in the patron's details in OPAC? - If both settings are OFF the user has no information in the OPAC, but we still show it on staff - not sure how to make this better. It feels a bit like this is not 'round' yet. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
