http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402
--- Comment #14 from M. Tompsett <[email protected]> --- (In reply to Jonathan Druart from comment #9) > QA comment: > > 4 smalls remarks: > 1/ FAIL install_misc/koha-debian-deps.pl > FAIL pod > *** ERROR: Spurious text after =pod in file > install_misc/koha-debian-deps.pl > Need a blank line under "=pod" Added blank line. > 2/ Please use Pod::Usage. Not sure how to do that, but it's likely related to the print_usage() function. > 3/ Maybe should you use > C4::Context->config('intranetdir') . '/debian/control' > instead of using a relative path. > I don't know if it is relevant given that is adds a dependence to > C4::Context. Which is good, because then: ./install_misc/koha-debian-deps.pl -r works nicely without having to be in a fixed location. > 4/ It is useless to return 1 at the end of a perl script. removed. Also, I probably should have cleaned up the licensing. ;) I was also disappointed, because the list generated does not include gcc, which is required for some of the makes. So, I think I'll leave this Failed QA. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
