http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #50 from M. de Rooy <[email protected]> --- QA Comment: Great work! No complaints from qa tools. Adjusted tests pass. Problem reported earlier has been resolved. Thanks for improving variable names. This illustrates that bad variable naming is a bug source. Also thanks for adding tests. Small note: Lines (without comment) like @values = map { $_ <= @values ? $values[ $_ - 1 ] : () } @$field_numbers; might be marked as somewhat obfuscating ;) The All/Every change is not really needed imo, and does not seem to work always when changing a condition. But np ;) This report does not deal with (nor introduce) this warning, but I just note that I would really like to get rid of it ;) Maybe, Kyle could resolve that one in least time.. Something with forks and STDOUT etc. stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at /usr/local/lib64/perl5/Template/Provider.pm line 964., referer: http://libdevelop.rijksmuseum.nl:8009/cgi-bin/koha/tools/stage-marc-import.pl Passed QA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
