http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #32 from David Cook <[email protected]> --- Could someone double-check adding a new suggestion via the OPAC? My git is pretty messy at the moment, and I'm balancing a few different things at once, so I might have to check later. However, when I try to add a suggestion via the OPAC in master, I get this error: DBIx::Class::Row::new(): No such column 'branch' on Koha::Schema::Result::Suggestion at /koha/dev/dcook/git/C4/Suggestions.pm line 449 When I look up on the script, I notice this: my $suggestion = $input->Vars; Which is rather nasty... and I notice this: delete $$suggestion{$_} foreach qw<op suggestedbyme>; Which is also rather nasty... -- In any case, the form from opac-suggestions.pl passes branchcode as "branch", but DBIC expects to receive "branchcode". So... I guess the easy fix is to probably change the template. (But we should probably be explicitly building the $suggestion hash rather than relying on $input->Vars, as all sorts of badness could be passed in there which will cause the script to croak) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
