http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944
--- Comment #18 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Comment on attachment 33197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33197 Bug 12944: Refactor the patron autocomplete Review of attachment 33197: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12944&attachment=33197) ----------------------------------------------------------------- Hi Jonathan, overall this looks good :) ::: koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js @@ +32,5 @@ > + }); > +} > + > +function AddPatron( patron_name, value, container, input_name ) { > + div = "<div id='borrower_" + value + "'>" + patron_name + " ( <a > href='#' class='removePatron'> " + _("Remove") + " </a> ) <input > type='hidden' name='" + input_name + "' value='" + value + "' /></div>"; But by moving the Javascript into a separate js file, the "Remove" will no longer be translatable. Could you please fix? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
