http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
--- Comment #10 from Jonathan Druart <[email protected]> --- (In reply to Katrin Fischer from comment #8) > Comment on attachment 31981 [details] [review] > Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl > > Review of attachment 31981 [details] [review]: > ----------------------------------------------------------------- > > ::: acqui/basketgroup.pl > @@ -212,5 @@ > > } > > } > > > > - my $ba_order = { > > - isbn => ($ord->{isbn} ? $ord->{isbn} : undef), > > Hi Jonathan, bit irritated by this line - was removing it intentional? I see > that that PDF should be printing the ISBN, but have a bit of trouble making > it work in my installation currently. Hi Katrin, Yes it is intentional. Actually before the patch, the $ba_order was pushed to @ba_orders. Now, the order $ord is pushed. We could add: $ord->{isbn} = $ord->{isbn} ? $order->{isbn} : undef; But it does not make sense, except if we need to manage the empty string or 0, but it would not be a valid ISBN. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
