http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34440|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <[email protected]> --- Created attachment 34869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34869&action=edit Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!! We failed to deliver advance_notices because a template for sms's is undefined, because we don't support sending sms' as advance_notice. This crashed the cronjob because digests are set to die instead of the warn used in non-digest. And we get angry customers asking for compensation! This patch replaces the die with warn. TEST PREPARATION: 0. Edit the ODUEDGST letter, find an undefined letter for any trasport type. TEST PLAN: 1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to the undefined digest. Set the "Days in Advance" to 1. 2. Check-out something for that borrower and set the due date for tomorrow. 3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal. 4. BEFORE THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." and the script dies. 4. AFTER THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." but the script keep on going! Signed-off-by: Jonathan Druart <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
